feat: likely_binary_ignore #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d44ca60)
Contributor
asottile-sentry
left a comment
asottile-sentry
left a comment
There was a problem hiding this comment.
looks good -- just a few tiny things
| if "/test/" in name or "/tests/" in name: | ||
| continue | ||
|
|
||
| if any(substr in name for substr in package.likely_binary_ignore): |
Contributor
There was a problem hiding this comment.
I think these would be better as exact matches?
|
|
||
|
|
||
| def _likely_binary(sdist: str) -> str | None: | ||
| def _likely_binary(package: Package, sdist: str) -> str | None: |
Contributor
There was a problem hiding this comment.
it'll be much easier to test if this takes likely_binary_ignore directly rather than the whole Package
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered as part of #75. Thought it would be better to put more specific cases in
packages.ini.edit: not needed anymore since #79, but gonna keep this around